kty: init at 0.3.1 #343264
Merged
kty: init at 0.3.1 #343264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
roosemberth
approved these changes
Sep 21, 2024
wegank
added
the
12.approvals: 1
Aleksanaa
approved these changes
Sep 22, 2024
Bot-wxt1221
added
12.approvals: 2
|
@Aleksanaa Could we merge this? |
Aleksanaa
reviewed
Sep 26, 2024
pkgs/by-name/kt/kty/package.nix
Outdated
Comment on lines
28
to
30
| buildInputs = [ | ||
| openssl | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ | |
| openssl | |
| ]; | |
| buildInputs = [ | |
| openssl | |
| ] ++ lib.optionals stdenv.isDarwin [ | |
| darwin.apple_sdk.frameworks.SystemConfiguration | |
| ]; |
lib.optionals (stdenv.isDarwin) has redundant parenthesis
There was a problem hiding this comment.
@Aleksanaa Solved.
Aleksanaa
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix #343215
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.